This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Include native files in Simulators project #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
approved these changes
Jul 10, 2020
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
Just one question below, but from an organizational standpoint all the changes look good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native files for the simulator, were getting included in the nuget package via the nuspec and not the csproj, which breaks when we want to replace package with project references for the simulators.
This makes sure the native files are also part of the project.