This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Generic Parameter Bug Fix #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
anpaz,
bamarsha,
bettinaheim,
cesarzc and
swernli
swernli
approved these changes
Jul 9, 2020
Contributor
|
Please wait with merging for @anpaz-msft to take a look at this one, since I believe there might be some perf considerations here. |
anpaz
approved these changes
Jul 10, 2020
Member
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
except for my two minor questions, lgtm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the method in the C# generation for determining if a callable is a generic callable. The old behavior counts the number of type parameters referenced in the types of the regular parameter list and the return type. This causes a bug to occur when type parameters are listed for a callable that are not used in their parameter list or return type. The new behavior simply counts the length of the type parameters list for the callable. See issue #299.