Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Fix stack overflow bug for Qubit array types #312

Merged
anpaz merged 4 commits into from
Jul 16, 2020
Merged

Fix stack overflow bug for Qubit array types #312

anpaz merged 4 commits into from
Jul 16, 2020

Conversation

@theRoughCode
Copy link
Contributor

@theRoughCode theRoughCode commented Jul 16, 2020 •
edited
Loading

There is a bug in GetNonQubitArgumentsAsString where arguments of Qubit array types (and QVoid) produced a stack overflow. That happened because IQArray matches IApplyData instead of the Qubit type. This PR fixes this by adding a check to see if the given arguments is of the type IEnumerable<Qubit> (or QVoid).

@theRoughCode theRoughCode requested review from anpaz and cgranade July 16, 2020 16:52
@theRoughCode theRoughCode self-assigned this Jul 16, 2020
anpaz
anpaz approved these changes Jul 16, 2020
View reviewed changes
@anpaz anpaz merged commit 08ae4a4 into master Jul 16, 2020
@theRoughCode theRoughCode deleted the raphael/qubit-args branch July 24, 2020 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cgranade cgranade Awaiting requested review from cgranade

1 more reviewer

@anpaz anpaz anpaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@theRoughCode theRoughCode

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theRoughCode @anpaz