This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Slice Bug Fix #330
Merged
Slice Bug Fix #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
requested review from
DmitryVasilevsky,
IrinaYatsenko,
bamarsha,
cesarzc and
swernli
bettinaheim
previously requested changes
Aug 13, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
There are tests missing here that capture the scenarios that this PR fixes.
bettinaheim
dismissed
their stale review
lgtm - let's give it a day in case anyone else has a concerns.
Contributor
Author
Issue #132 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the nullable member access with regular member access for Slice.