This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Protect simulator accessors via shared lock #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
force-pushed
the
swernli/fix-namespaces
branch
from
5660767 to
87ae2e8
Compare
Collaborator
Author
|
I've introduced a bug somewhere with how the new |
This fixes an intermittent crash by putting shared locks around the access of the `psis` vector, where create and destroy use an exclusive lock of the same mutex Fixes #335
swernli
force-pushed
the
swernli/fix-namespaces
branch
from
75ce934 to
83e0c6e
Compare
swernli
commented
Aug 14, 2020
| { | ||
| namespace Simulator | ||
| { | ||
| mutex_type _mutex; |
Collaborator
Author
There was a problem hiding this comment.
@dbwz8 This code used to use the #define that resolves to omp_mutex when OpenMP support is enabled. However, this code doesn't interact with any other OpenMP code/classes, so I think it should be safe to use the std class instead, especially since we compile with C++17 across all platforms now. Please let me know if this assumption is safe, and if not we can look at other solutions!
bettinaheim
approved these changes
Aug 14, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
lgtm, but Dave is more familiar with the simulator than I am.
dbwz8
approved these changes
Aug 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an intermittent crash by putting shared locks around the access of the
psisvector, where create and destroy use an exclusive lock of the same mutexFixes #335