This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix stackoverflow error for QArray args #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the StackOverflow error encountered in #270. This is because arguments of type
bool[]in Q# are represented asIQArray<Boolean>in the simulator which should get matched to an array type withinGetNonQubitArgsAsStringbut instead matches theIApplyDatatype. When that happens, we encounter an infinite loop:IQArray<Boolean>->System.RuntimeType->System.RuntimeType-> ...To fix this, we move the check for
IApplyDatato the bottom so that we match that case last (as it's the culprit for stack overflow errors). As further precaution, we also add a check to see ifIApplyData.Valueis the same as the original value, preventing possible infinite recursion.