This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Skip Csharp Generation of references with test names if not using test name #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makse it so that C# generation for references that have a test name attribute only happens when loading via test names is requested.
swernli
changed the title
ScottCarda-MS
approved these changes
Aug 24, 2020
Remove unused `e` variable. Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of the functionality introduced in microsoft/qsharp-compiler#581 that allows rewrite steps to know if
ExposeReferencesViaTestNameswas specified for the current compilation. Then CsharpGeneration rewrite step can only re-generate C# for references that both have a test name defined AND are being loaded by that test name. This fixes a bug where callables with a test name attribute would end up colliding with themselves if they were referenced without test name.This was tested by temporarily adding a test name attribute to
Microsoft.Quantum.Intrinsic.Measure, which would cause a compilation failure without these changes and compiles successfully with these changes.