This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adding scheduler enhancement for simulator performance boost #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial simulator fixes Includes generator scripts that create the kernels.
* Create a separate package for the entry point driver (#225) * Add EntryPointDriver to pack.ps1 * Rename Microsoft.Quantum.Simulation.Simulators to Microsoft.Quantum.Simulators * Rename EntryPointDriver to Microsoft.Quantum.EntryPointDriver * Rename Tests.EntryPointDriver to Microsoft.Quantum.EntryPointDriver.Tests * Add package description for EntryPointDriver * Remove EntryPointDriver from CsharpGeneration package * Update namespace in EntryPointDriver * Update namespace in EntryPointDriver.Tests * Update simulator test project filename * Update manifest.ps1 * Rename Microsoft.Quantum.EntryPointDriver.Tests to Tests.Microsoft.Quantum.EntryPointDriver * Restore name of simulators assembly * Add DelaySign.cs to EntryPointDriver * Use same assembly name as package name again * Update reference to simulators csproj * Update simulators nuspec * Update project reference to simulators * Update namespace names in test * Remove package reference to Q# compiler * Use IImmutableList instead of IReadOnlyList * Use ImmutableList.Create with params array * Make DriverSettings immutable * Make DriverSettings properties internal * Add PackageId to EntryPointDriver.csproj * Fix NUGET_VERSION issues (#251) * Fix assembly vs nuget version in pack.ps1. * Fix project vs package reference. * Feedback from @bettinaheim. * Added AVX512 * Add fma for AVX512 Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Dave Wecker <wecker@microsoft.com>
Merging changes from master
* Merging Linux simulator update from dbwz8/simDbg * Remove extra semicolon
…into t-anikda/experimental
Updates from master
…crosoft/qsharp-runtime into t-anikda/experimental
dbwz8
reviewed
Aug 27, 2020
dbwz8
reviewed
Aug 27, 2020
dbwz8
reviewed
Aug 27, 2020
dbwz8
reviewed
Aug 27, 2020
dbwz8
reviewed
Aug 27, 2020
| @@ -0,0 +1,364 @@ | |||
| # CMAKE generated file: DO NOT EDIT! | |||
Contributor
There was a problem hiding this comment.
Makefiles are generated by CMake... should be checked in
Collaborator
Author
There was a problem hiding this comment.
Is this still a concern? The file is present in the change, but perhaps you comment meant to say "shouldn't" be checked in? I could remove that file if that is preferable.
dbwz8
reviewed
Aug 27, 2020
Pulling in fixes and clean-up from dbwz8/simulator-enhancement
swernli
commented
Aug 30, 2020
dbwz8
approved these changes
Aug 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in work done by @AniketDalvi, @dbwz8, and myself to enhance the native simulator with gate scheduling and clustering, leading to significant performance increases (originally part of the feature/simulator-enhancement branch). It also includes new tests that verify the performance, and a folder with benchmark projects to help with future performance comparisons. In our benchmarking, this led to between a 4x and 6x improvement, and could be significantly more depending on the host environment or circuit composition.