This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adding handling of branching based on measurement results to SimulatorBase #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the handling of branching based on measurement results to SimulatorBase, exposing the virtual methods
The PR removes the duplicated logic in the QuantumSimulator and the Tracer.
It also fixes the incorrect event spawned by Borrow, and contains other minor changes regarding which members are virtual, private, and protected.
Since there are more PRs coming that impact the API, it may make sense to merge this to a feature branch. However, I am also trying to avoid having several feature branches with a large amount of changes that require coordination (the decomposition work comes to mind), and this change should be fairly lightweight.