Unifying the two qubit managers #370
Conversation
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
I have a few clarifying questions to help put the refactor in context (some of which are regarding functionality that was not changed in the refactor). Thanks!
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Thanks for tagging me into the discussion; left a few thoughts by way of early feedback. Thanks!
src/Simulation/Simulators/QuantumProcessor/QuantumProcessorDispatcher.cs
Show resolved
Hide resolved
Co-authored-by: Chris Granade <chgranad@microsoft.com>
Co-authored-by: Chris Granade <chgranad@microsoft.com>
alan-geller
left a comment
alan-geller
left a comment
There was a problem hiding this comment.
A few small comments, a couple of bigger ones.
This is a long-overdue simplification -- thanks!!!
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
Have we checked that there are no perf regressions with these changes?
They also include breaking changes, so we should update the minor.
There is no functional or algorithmic change; this is merely an API change. We certainly monitor perf for everything. |
This is still a draft, since I have yet to confirm whether the API is sufficient or whether we need to keep more.