This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Include inner exception in message of WorkspaceClientException #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s available to Azure CLI output.
cesarzc
approved these changes
Sep 17, 2020
ricardo-espinoza
added a commit
that referenced
this pull request
Sep 23, 2020
…ionable information (#380) Improving the logging of WorkspaceClientException to include more informative data in its message from its inner exception. This is a follow up to #378 . - Instead of providing the full stack of the exception in the output, we extract more relevant fields from the source RestErrorException and provide them to the user. - Also, this change exposes header "x-ms-request-id"if present in the response, for additional debugging.
cgranade
pushed a commit
that referenced
this pull request
Sep 23, 2020
…ionable information (#380) (#386) Improving the logging of WorkspaceClientException to include more informative data in its message from its inner exception. This is a follow up to #378 . - Instead of providing the full stack of the exception in the output, we extract more relevant fields from the source RestErrorException and provide them to the user. - Also, this change exposes header "x-ms-request-id"if present in the response, for additional debugging. Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the message in WorkspaceClientException to include the inner exception as well if present.
This exception message is provided to the user through the console during execution (e.g. when using the Azure CLI) and should include this information to be more actionable.