This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Create the correct default values of Q# types #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
October 15, 2020 12:52
added 2 commits
October 16, 2020 17:09
swernli
approved these changes
Oct 19, 2020
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
The reflection you are using here to get info on the underlying generic types seems reasonable to me. I don't know of any other ways to handle these kinds of types, and I've seen this approach recommended elsewhere (and used it myself for some .NET that wraps WMI). I'd definitely let others weigh in too, though I'm of the opinion this is the way C# is meant to handle generics.
bettinaheim
reviewed
Oct 20, 2020
Contributor
bettinaheim
left a comment
bettinaheim
left a comment
There was a problem hiding this comment.
Could you please double check the perf tests? Thanks!
Contributor
Author
This turns out to not be easy. Currently, the runtime performance tests aren't published in a format that's convenient to compare against results from main. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #359.