QIR-based tracer #475
QIR-based tracer #475
Conversation
IrinaYatsenko
requested review from
bettinaheim,
cesarzc,
msoeken,
swernli,
thomashaener and
vadym-kl
thomashaener
left a comment
thomashaener
left a comment
There was a problem hiding this comment.
Thanks a lot, @irinayat-MS, looks good to me!
I've added a few suggestions and comments.
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
I left only a few comments for now.
IrinaYatsenko
force-pushed
the
irinayat/tracer
branch
2 times, most recently
from
1c35c3b to
f394387
Compare
IrinaYatsenko
force-pushed
the
irinayat/tracer
branch
4 times, most recently
from
203ddd3 to
e8d4f45
Compare
| @TargetInstruction("inject_global_barrier") | ||
| operation Barrier(id : Int, duration : Int) : Unit |
There was a problem hiding this comment.
Similarly here, this looks like a proposal for a new Q# intrinsic operation? If so, would be willing to write an issue on QuantumLibraries so that we can get it scheduled for the next API review? Thanks!
There was a problem hiding this comment.
@bettinaheim, I suspect that eventually we'll need barriers to be in the public interface but I'm not sure of the timeline. For now, I've moved it into the Tracer namespace to allow for experimentation and testing but should we kick off the motions to add it to the libraries as well?
There was a problem hiding this comment.
I think that would make sense, yeah. No harm in getting the Q# API reviewed in advance so that the approval is ready and in place for whatever timelines work on the C&R side.
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Can you please show the updated README.md?
|
Reapproving. |
To collect early feedback on the tracer design.
lib/tracercontains implementation of the tracer (the readme file in the folder outlines the requirements and design)test/unittests/TracerTests.cppcontains C++ unit tests for the tracertest/QIR-tracerdemonstrates how a Q# program can be connected to the tracer via QIR