-
Notifications
You must be signed in to change notification settings - Fork 90
Conversation
cgranade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these samples intended to be user-facing or contributor-facing? If so, we should make sure they are located in repos that onboard to our samples publication pipeline, and that they have all required metadata for said onboarding (see internal wiki for details).
These samples are contributor-facing. The idea is to have a few examples to know how the generated C++ driver for QIR should look like, so these samples might get replaced or removed at some point when the compiler generates a QIR executable. |
Co-authored-by: Chris Granade <chgranad@microsoft.com>
|
@cgranade for some reason, the reply box is not shown for this message but yes, CLI11.hpp is where |
|
Thank you @irinayat-MS and @cgranade for your comments! I'll address them shortly. I just wanted to mention that this PR is still work in progress so some things might change considerably. |
|
I'm done with the first pass of this PR. I didn't dive deep into the code that uses CLI11 library. I have a single GitHub account tied with my own email at gmail.com (which I check rarely, up to couple of times per day). So if you need my attention to a PR or an issue/bug open on GitHub, then please notify me over Teams or MS email. |
Thanks for the review Robin! Fixed the issue and it should be ready to merge now. |
kuzminrobin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with minor recommendations.
This change implements multiple entry point drivers for different QIR programs.