This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Updating ClassicalControls to reduce intrinsics #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the structure of the classical control ApplyIf* and ApplyControlled* callables in terms of each other to reduce 8 intrinsics to 2 intrinsics. Also updates the qir-gen.csproj to use the local QSharp.Core project instead of the one from the QDK for easier testing.
Contributor
|
How much of a race is this PR with #527? Shall I wait with merging 527 and remove the adj/ctl bridge APIs from it? |
Collaborator
Author
|
That's up to you, @irinayat-MS ; I think we know what updates would be need to made to the conditional support in #527 if it merges first. If you are ok waiting, then that will be two PRs instead of 3, but either way I don't think it's a problem. |
Contributor
|
OK. I've set 527 to merge automatically. If it merges successfully I'll follow up after yours to validate that we can remove the bridge for adj/ctl APIs. If it fails for whatever reason and your PR merges first, I'll align it with your refactor in a single change. |
This was referenced Feb 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the structure of the classical control ApplyIf* and ApplyControlled* callables in terms of each other to reduce 8 intrinsics to 2 intrinsics. Also updates the qir-gen.csproj to use the local QSharp.Core project instead of the one from the QDK for easier testing.