This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Added Parity() to the Q# library, and the tests. #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgranade
reviewed
Feb 24, 2021
cgranade
reviewed
Feb 25, 2021
cgranade
approved these changes
Feb 25, 2021
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
This PR does modify the behavior of a Q# standard library function, but having read through I think that makes sense — the current behavior is really a bug in the C#-based runtime caused by a cast to ulong. From that perspective, I'm happy to approve and skip formal API review.
kuzminrobin
force-pushed
the
kuzminrobin/otherfuncs
branch
from
986ceff to
af54e13
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are quite different from the ones in my previous PRs.
Some of the changes here go to the Q# library rather than to QirRuntime. So I wanted this PR to be reviewed separately from the subsequent changes.