This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Make non-intrinsic ClassicalControl callables internal #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Collaborator
Author
|
Huh, I didn't anticipate how this change would negatively interact with the QIR tests for classical control helpers. I need to see if there is a way to both make this change and keep those tests working... |
Collaborator
Author
|
Upon further review, making these helpers internal is not a goal for our design (we want people to be able to write Q# code that calls into them, and it it turns out making them actually internal is very hard). Closing this in favor of keeping the API public. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the clean-up of classical control helper callables by making them internal. See #534.