This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Added PauliArrayAsInt() and tests. #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
requested review from
IrinaYatsenko,
bettinaheim,
cgranade and
swernli
kuzminrobin
commented
Mar 2, 2021
Contributor
Author
|
Please review. |
cgranade
reviewed
Mar 2, 2021
Contributor
Author
|
Updated the PR with the CR changes. |
Contributor
Author
|
Please review when you have a chance. |
Contributor
Author
|
This PR has been hanging for a while. Please review. |
swernli
suggested changes
Mar 9, 2021
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
Apologies for the delay. I see one change that would need to be made to ensure this is covered by existing tests.
kuzminrobin
force-pushed
the
kuzminrobin/otherfuncs2
branch
from
5bf5d1c to
4a89a66
Compare
Contributor
Author
|
Addressed all the feedback. Please review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid losing my local changes, while I'm working on the other functions, I'd like to get this change through the code review.