This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Adapt runtime to latest LSP package. #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
reviewed
Mar 5, 2021
| <ItemGroup> | ||
| <PackageReference Update="FSharp.Core" Version="4.7.0" /> | ||
| <PackageReference Include="Microsoft.Quantum.Compiler" Version="0.15.2102129527-alpha" /> | ||
| <PackageReference Include="Microsoft.Quantum.Compiler" Version="0.15.2103130749-beta" /> |
Collaborator
There was a problem hiding this comment.
To update this version, you need to also update every QDK version through the whole repo. However, because there are changes in qsharp-runtime main that aren't yet in qsharp-compiler main, doing so to a beta package that is missing those dependent changes means it will fail the build. We are working in getting out of this bad state, but for now our best bet is to merge compiler main into one of our working branches, do an alpha build, and and then have you update to that package version across this repo.
I'll kick off a build that hopefully will resolve this issue for you.
ricardo-espinoza
approved these changes
Mar 12, 2021
ricardo-espinoza
added a commit
that referenced
this pull request
Mar 12, 2021
* Update simulation code tests to use latest LSP API. * Update entry point generator tests as well. * Update to latest compiler beta. * Update ci.yml * Update SDK version across repository to 0.15.2103130749-beta * Fixing remaining file for SDK version Co-authored-by: Ricardo Espinoza <ricardoe@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to the runtime needed to support microsoft/qsharp-compiler#886.