Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@swernli
Copy link
Collaborator

@swernli swernli commented Mar 12, 2021

I forgot to include the generated import libs needed for compiling against the dlls on Windows in the build artifacts for the QIR runtime.

@swernli swernli marked this pull request as draft March 12, 2021 09:31
@swernli
Copy link
Collaborator Author

swernli commented Mar 12, 2021

@cesarzc This is kind of annoying, and I wanted to give you the heads up. To use dlls at runtime on Windows we need to provide matching import libs which have the info needed for the linker. However, the only way to make sure those get "binplaced" by our install command in cmake is to include ARCHIVE which will also end up copying out any static libs that are generated. For now, I'm just putting all *.lib files into the drops folder for Windows, but once we get a formal packaging process we can be more discerning about which libs are included and avoid causing confusion by packing static libs that are redundant to the dynamic libraries produced.

@swernli swernli marked this pull request as ready for review March 12, 2021 17:32
@swernli swernli enabled auto-merge (squash) March 12, 2021 17:33
@swernli swernli merged commit 5e5c597 into main Mar 12, 2021
@cesarzc
Copy link
Contributor

cesarzc commented Mar 12, 2021

@cesarzc This is kind of annoying, and I wanted to give you the heads up. To use dlls at runtime on Windows we need to provide matching import libs which have the info needed for the linker. However, the only way to make sure those get "binplaced" by our install command in cmake is to include ARCHIVE which will also end up copying out any static libs that are generated. For now, I'm just putting all *.lib files into the drops folder for Windows, but once we get a formal packaging process we can be more discerning about which libs are included and avoid causing confusion by packing static libs that are redundant to the dynamic libraries produced.

Thanks for the heads up @swernli!

swernli added a commit that referenced this pull request Mar 12, 2021
* Copy generated import lib for QIR on Windows

* Make sure libs get installed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants