This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix dynamic assembly load logic in Tracer #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the fallback logic in the `QCTraceSimulator` for dynamically loading the QSharp.Core target package wouldn't work for manually written C# drivers. This fixes the issue by introducing new fallback logic that relies on the assembly name of the current simulator assembly to determine the full name of the QSharp.Core assembly to load. Fixes #540 Fixes #542
ScottCarda-MS
approved these changes
Mar 19, 2021
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Looks good! I guess I thought it would be more complicated than that, but simple solutions are great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the fallback logic in the
QCTraceSimulatorfor dynamically loading the QSharp.Core target package wouldn't work for manually written C# drivers. This fixes the issue by introducing new fallback logic that relies on the assembly name of the current simulator assembly to determine the full name of the QSharp.Core assembly to load.Fixes #540
Fixes #542