Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@kuzminrobin
Copy link
Contributor

Stage 1 to resolve the #578

@kuzminrobin kuzminrobin marked this pull request as ready for review March 23, 2021 03:35
@swernli
Copy link
Collaborator

swernli commented Mar 23, 2021

The build failure looks like an unrelated intermittent crash. You can try rerunning the failed job using the button at the top of the page and that will probably pass now. Changes look good!

@bettinaheim
Copy link
Contributor

The build failure looks like an unrelated intermittent crash. You can try rerunning the failed job using the button at the top of the page and that will probably pass now. Changes look good!

Hu, I only see a not very informative "The active test run was aborted. Reason: Test host process crashed". I haven't seen this so far; has this been happening lately?

@kuzminrobin kuzminrobin enabled auto-merge (squash) March 23, 2021 15:22
@kuzminrobin kuzminrobin merged commit dce2456 into main Mar 23, 2021
@kuzminrobin kuzminrobin deleted the kuzminrobin/message branch March 23, 2021 17:13
@kuzminrobin kuzminrobin linked an issue Mar 23, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the Message() implementation from QIS to RT

4 participants