This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Update reference C++ entry-point driver to use the latest QIR emission #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettinaheim
approved these changes
Mar 23, 2021
src/QirRuntime/samples/StandaloneInputReference/qsharp/qir-standalone-input-reference.qs
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
kuzminrobin
reviewed
Mar 23, 2021
kuzminrobin
approved these changes
Mar 23, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Approved with suggestion.
kuzminrobin
reviewed
Mar 23, 2021
src/QirRuntime/samples/StandaloneInputReference/qsharp/qir-standalone-input-reference.qs
Outdated
Show resolved
Hide resolved
kuzminrobin
reviewed
Mar 23, 2021
src/QirRuntime/samples/StandaloneInputReference/qsharp/qir-standalone-input-reference.qs
Outdated
Show resolved
Hide resolved
Contributor
|
Reapproving. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the reference C++ entry-point driver to be compatible with the latest QIR emission.
One of the important changes is that it is now assumed that interop QIR functions are always
void.