This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Enumerated File Names for Generated C# #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I will need to find a way to add tests for this. @bettinaheim if you have any suggestions or similar existing tests, that would be helpful to look at. |
kuzminrobin
approved these changes
Apr 1, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
I don't understand the code for now.
To not delay the development I'm approving, but I recommend to get at least one more approval.
Moved Files to properly-cased directory.
Contributor
Author
Tests have been added now. |
ScottCarda-MS
force-pushed
the
sccarda/EnumeratedFileNames
branch
from
7bcbfc5 to
cdeef55
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the output for the C# Generation rewrite step to always put all of the generated files in the given output directory directly, not in subfolders and not respecting relative locations of their corresponding Q# source files. The naming convention for generated C# files is being updated to include a number when their is a name collision. For example, if
Main.g.cshas already been written during a compilation and anotherMain.g.csfile is going to be written, it will instead writeMain.g1.cs, and if that file also already exists,Main.g2.cs, and so on. There is a hardcoded limit at 100 enumerations of the same file name, soMain.g99.cswould be the last possible file name. The enumeration always precedes the final.cs.