This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Separate QIR Runtime from Tests and Samples #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swernli
requested review from
anpaz,
bamarsha,
bettinaheim,
cesarzc and
kuzminrobin
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
reviewed
Apr 2, 2021
anpaz
approved these changes
Apr 2, 2021
Member
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
lgtm. as we talked, we should add the qir dlls to the manifest so they get signed, but other than that i have no concerns.
kuzminrobin
reviewed
Apr 2, 2021
kuzminrobin
approved these changes
Apr 2, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Approving with suggestions.
cesarzc
reviewed
Apr 2, 2021
cesarzc
reviewed
Apr 2, 2021
cesarzc
approved these changes
Apr 2, 2021
Contributor
cesarzc
left a comment
cesarzc
left a comment
There was a problem hiding this comment.
Looks good! Approving with a couple of suggestions.
This change separates the QIR Runtime (production code) from the tests and samples. Since the Runtime has no Q# dependencies, we can now pull it into the native build step of the e2e pipeline to better produce cross-platform binaries from the builds.
swernli
force-pushed
the
swernli/qir-build-native
branch
from
3678dc4 to
f6a7350
Compare
This was referenced Apr 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change separates the QIR Runtime (production code) from the tests and samples. Since the Runtime has no Q# dependencies, we can now pull it into the native build step of the e2e pipeline to better produce cross-platform binaries from the builds.