This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Remove duplication of Quantum SDK version number #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That's a really neat way to use global.json (and indeed, speaks well to the value of making Microsoft.Quantum.Sdk an SDK-style package)! I'd be interested in duplicating this on the libraries repo as well (samples less so, since users will copy and paste each sample such that it's good if samples work without needing repo-wide config files — as noted with @swernli there are exceptions to that, but those exceptions should be carefully considered). |
cgranade
approved these changes
Apr 7, 2021
Contributor
cgranade
left a comment
cgranade
left a comment
There was a problem hiding this comment.
Approving as it looks good to me, but may want a second opinion from someone closer to runtime.
swernli
approved these changes
Apr 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use global.json to specify the package version of Microsoft.Quantum.Sdk in one place.
The only other place this version number appears is in the dependency on Microsoft.Quantum.Compiler in the CSharpGeneration project. I'm not sure there is a good way to unify these two, but I suspect those package versions don't need to be in sync with each other in the same way that the SDK version numbers need to, so this could be good enough to close #530.