This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Include QIR Runtime binaries and headers in drops #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the build script to copy the QIR Runtime binaries and headers into the drops folder. This will ensure that during PR builds (non-e2e) the corresponding cross-platform binaries are still produced as build artifacts.
Collaborator
Author
|
The artifacts are showing up as expected, as you can see from this build: https://dev.azure.com/ms-quantum-public/Microsoft%20Quantum%20(public)/_build/results?buildId=25419&view=artifacts&pathAsName=false&type=publishedArtifacts |
anpaz
approved these changes
Apr 8, 2021
Member
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
lgtm.
the only comment is, should this go into qir-utils.ps1 to follow the same pattern?
Collaborator
Author
|
Good question. In this case, the only binaries that we want to copy out are the runtime, so it really is specific to that folder. When/if we have other folders whose binaries we want to produce as artifacts, it will probably make sense to refactor and pull this logic into the utils. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the build script to copy the QIR Runtime binaries and headers into the drops folder. This will ensure that during PR builds (non-e2e) the corresponding cross-platform binaries are still produced as build artifacts.