Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@bamarsha
Copy link
Contributor

This PR is based on #624 but adds data types for representing the arguments to an entry point.

@bamarsha bamarsha requested review from cesarzc and swernli April 14, 2021 20:55
@cesarzc
Copy link
Contributor

cesarzc commented Apr 16, 2021

It seems like the only thing left to agree on is whether the new interfaces should have the *Submitter suffix.

@bamarsha
Copy link
Contributor Author

I renamed the new interfaces to IQirSubmitter and IAzureSubmitter. Also, as a note for the future, IQuantumMachine should probably be IQSharpSubmitter, since I think it specifically submits Q# programs.

@swernli
Copy link
Collaborator

swernli commented Apr 16, 2021

I like the rename! Thanks for landing at something more descriptive.

@cesarzc
Copy link
Contributor

cesarzc commented Apr 16, 2021

I like the rename too!

@bamarsha bamarsha changed the title Add IQirMachine interface Add IQirSubmitter interface Apr 16, 2021
@bamarsha
Copy link
Contributor Author

I'm wondering if the Windows build errors would be fixed by #627 if main is merged into feature/azure-quantum-simulator-client?

@cesarzc
Copy link
Contributor

cesarzc commented Apr 19, 2021

I think merging main will likely fix the problem. Thanks for creating the merge PR.

@bamarsha bamarsha merged commit 7501e16 into feature/azure-quantum-simulator-client Apr 19, 2021
@bamarsha bamarsha deleted the samarsha/qir-machine-interface branch April 19, 2021 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants