This repository was archived by the owner on Jan 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Add IQirSubmitter interface
#627
Merged
bamarsha
merged 20 commits into
feature/azure-quantum-simulator-client
from
samarsha/qir-machine-interface
Apr 19, 2021
Merged
Add IQirSubmitter interface
#627
bamarsha
merged 20 commits into
feature/azure-quantum-simulator-client
from
samarsha/qir-machine-interface
Apr 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bamarsha
commented
Apr 14, 2021
bamarsha
commented
Apr 15, 2021
Contributor
|
It seems like the only thing left to agree on is whether the new interfaces should have the |
Contributor
Author
|
I renamed the new interfaces to |
Collaborator
|
I like the rename! Thanks for landing at something more descriptive. |
Contributor
|
I like the rename too! |
cesarzc
reviewed
Apr 16, 2021
Contributor
Author
|
I'm wondering if the Windows build errors would be fixed by #627 if main is merged into feature/azure-quantum-simulator-client? |
Contributor
|
I think merging main will likely fix the problem. Thanks for creating the merge PR. |
cesarzc
approved these changes
Apr 19, 2021
…ir-machine-interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #624 but adds data types for representing the arguments to an entry point.