This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Introduce ClassicalControl namespace, depreicate old namespace #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the implementation of the callables used by the Classical Control rewrite step into a new namespace, Microsoft.Quantum.ClassicalControl. The old callables in the Microsoft.Quantum.Simulation.QuantumProcessor.Extensions are marked as depricated and will be removed in a later PR. Follow up will need to be done across the remaining repos where explicit references to this namespace exist (such as in the compiler rewrite step itself) to move to the new namespace.
6 tasks
ScottCarda-MS
approved these changes
May 17, 2021
Contributor
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
There was a problem hiding this comment.
Looks good! There should be a related PR made on the compiler repo that updates to use the new namespace as well. One place that needs updating that I can think of is here: https://github.com/microsoft/qsharp-compiler/blob/main/src/QsCompiler/Core/Dependencies.fs#L27
In the mean time, the compiler would just end up using the depreciated definitions defined in this PR.
swernli
added a commit
to microsoft/qsharp-compiler
that referenced
this pull request
May 17, 2021
This change takes advantage of the update done in microsoft/qsharp-runtime#692 to use the new namespaces for Classical Control operations.
swernli
added a commit
to microsoft/qsharp-compiler
that referenced
this pull request
May 17, 2021
* Updating ClassicalControl rewrite to use new namespace This change takes advantage of the update done in microsoft/qsharp-runtime#692 to use the new namespaces for Classical Control operations. * Update QIR test for new namespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the implementation of the callables used by the Classical Control rewrite step into a new namespace, Microsoft.Quantum.ClassicalControl. The old callables in the Microsoft.Quantum.Simulation.QuantumProcessor.Extensions are marked as depricated and will be removed in a later PR. Follow up will need to be done across the remaining repos where explicit references to this namespace exist (such as in the compiler rewrite step itself) to move to the new namespace.