This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Use of exceptions recommendation #719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
reviewed
Jun 8, 2021
kuzminrobin
requested review from
ScottCarda-MS,
bamarsha,
bettinaheim,
cesarzc,
cgranade,
msoeken and
swernli
kuzminrobin
reviewed
Jun 8, 2021
kuzminrobin
reviewed
Jun 8, 2021
Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com>
Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com>
msoeken
approved these changes
Jun 9, 2021
Member
msoeken
left a comment
msoeken
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @DmitryVasilevsky
Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com>
kuzminrobin
reviewed
Jun 9, 2021
kuzminrobin
reviewed
Jun 9, 2021
kuzminrobin
reviewed
Jun 10, 2021
kuzminrobin
reviewed
Jun 10, 2021
kuzminrobin
reviewed
Jun 10, 2021
kuzminrobin
reviewed
Jun 10, 2021
kuzminrobin
reviewed
Jun 10, 2021
kuzminrobin
reviewed
Jun 10, 2021
Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com>
kuzminrobin
approved these changes
Jun 11, 2021
Contributor
kuzminrobin
left a comment
kuzminrobin
left a comment
There was a problem hiding this comment.
Looks good. Thank you for the help, Dmitry.
kuzminrobin
added a commit
that referenced
this pull request
Jun 14, 2021
* Initial add of QIR-RT-API-Design-Guidelines.md * Use of exceptions recommendation (#719) * Co-authored-by: Mathias Soeken * Co-authored-by: DmitryVasilevsky
anpaz
added a commit
that referenced
this pull request
Jun 16, 2021
* Update API docs with more examples. (#701) Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * QIR runtime heap alloc and heap free functions removed (#703) * QIR runtime heap alloc and heap free functions removed * Implement Feedback Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * Add QIR Runtime to bootstrap script (#706) * Increasing the CMAKE required version for QIR (#708) This updates the required version for CMAKE in the CMakeLists.txt files for QIR, since we are now using features not correctly supported on older versions. * Added first version of Qubit manager to QIR (#696) This is the first version of the native Qubit Manager for QIR. Initial unit tests are included. Qubit Manager supports * Allocation and release of qubits including arrays of qubits. * Reuse encouraged/discouraged. Extending capacity enabled/disabled. * Restricted reuse areas and segments to support low-depth circuits. Qubit manager builds and tests are run as part of the qir-runtime-unittests. It is used in the bridge to the full state simulator. Commits: * Added first draft version of Qubit manager to QIR * Review feedback. Rearranged functions, QubitIdType, consts, etc. * include cstring for memcpy * Renamed QubitManager * Adjustment after QubitManager rename * Moved QubitManager.h to public * Using QubitManager, adjusted defaults, minor fixes * Removed unused comment * CR feedback: fixes to types, failures, braces, etc. * CR feedback - updated types, unique_ptr, etc. * Auxilliary stuff is now nested in CQubitmanager * Initializer lists * Updated CRestrictedReuseAreaStack and used iterator. * int32_t, more checks, some refactoring * Refactoring: marking and counting is done in allocate/release qubit id * Deletion of qubit object, protected members for overrides, Is...Qubit renames * Moved allocated marking to listQubitListInSharedArray class * Added comments, mostly status array * Tests, refactoring, replaced IsFreeQubit with IsFreeQubitId Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com> * Added treating warnings as errors (#718) * Added "QIR Runtime API Design Guidelines" (#711) * Initial add of QIR-RT-API-Design-Guidelines.md * Use of exceptions recommendation (#719) * Co-authored-by: Mathias Soeken * Co-authored-by: DmitryVasilevsky * Auto emulation rewrite step (#514) * First proposal for auto emulation feature. * Deprecation. * Update to newer version. * Successful tests. * Compatibility checks. * Do not change this file. * Signature checking too restrictive. * Add integration test. * Update QDK version. * Incorporate microsoft/QuantumLibraries#426. * Rename emulation to substitution. * Rename projects and directories. * Packaging. * Fix line-feed problems. * Fix LF. * Adressing reviewer feedback. * Update Sdk version. * Fixes dependency error. Co-authored-by: Mathias Soeken <masoeken@microsoft.com> Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * Added compiler warning flags -Wall, -Wextra (#725) * Added -Wall, -Wextra * Add DelaySign.cs to AutoSubstitution project. (#729) * extra sln Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> Co-authored-by: Pankaj Patil <pankaj.patil2099@hotmail.com> Co-authored-by: DmitryVasilevsky <60718360+DmitryVasilevsky@users.noreply.github.com> Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com> Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com> Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com> Co-authored-by: Mathias Soeken <masoeken@microsoft.com>
anpaz
added a commit
that referenced
this pull request
Jun 17, 2021
* Replace generated files in Quantum.Client with reference to the Azure.QuantumJobs package (#697) * Changes to enable Mocks for iq# and integrate with Live tests (#707) * Credentials parameter (#721) * Move to CredentialFactory. * Adding support for DeviceCode * Merge main (#731) * Update API docs with more examples. (#701) Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * QIR runtime heap alloc and heap free functions removed (#703) * QIR runtime heap alloc and heap free functions removed * Implement Feedback Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * Add QIR Runtime to bootstrap script (#706) * Increasing the CMAKE required version for QIR (#708) This updates the required version for CMAKE in the CMakeLists.txt files for QIR, since we are now using features not correctly supported on older versions. * Added first version of Qubit manager to QIR (#696) This is the first version of the native Qubit Manager for QIR. Initial unit tests are included. Qubit Manager supports * Allocation and release of qubits including arrays of qubits. * Reuse encouraged/discouraged. Extending capacity enabled/disabled. * Restricted reuse areas and segments to support low-depth circuits. Qubit manager builds and tests are run as part of the qir-runtime-unittests. It is used in the bridge to the full state simulator. Commits: * Added first draft version of Qubit manager to QIR * Review feedback. Rearranged functions, QubitIdType, consts, etc. * include cstring for memcpy * Renamed QubitManager * Adjustment after QubitManager rename * Moved QubitManager.h to public * Using QubitManager, adjusted defaults, minor fixes * Removed unused comment * CR feedback: fixes to types, failures, braces, etc. * CR feedback - updated types, unique_ptr, etc. * Auxilliary stuff is now nested in CQubitmanager * Initializer lists * Updated CRestrictedReuseAreaStack and used iterator. * int32_t, more checks, some refactoring * Refactoring: marking and counting is done in allocate/release qubit id * Deletion of qubit object, protected members for overrides, Is...Qubit renames * Moved allocated marking to listQubitListInSharedArray class * Added comments, mostly status array * Tests, refactoring, replaced IsFreeQubit with IsFreeQubitId Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com> * Added treating warnings as errors (#718) * Added "QIR Runtime API Design Guidelines" (#711) * Initial add of QIR-RT-API-Design-Guidelines.md * Use of exceptions recommendation (#719) * Co-authored-by: Mathias Soeken * Co-authored-by: DmitryVasilevsky * Auto emulation rewrite step (#514) * First proposal for auto emulation feature. * Deprecation. * Update to newer version. * Successful tests. * Compatibility checks. * Do not change this file. * Signature checking too restrictive. * Add integration test. * Update QDK version. * Incorporate microsoft/QuantumLibraries#426. * Rename emulation to substitution. * Rename projects and directories. * Packaging. * Fix line-feed problems. * Fix LF. * Adressing reviewer feedback. * Update Sdk version. * Fixes dependency error. Co-authored-by: Mathias Soeken <masoeken@microsoft.com> Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> * Added compiler warning flags -Wall, -Wextra (#725) * Added -Wall, -Wextra * Add DelaySign.cs to AutoSubstitution project. (#729) * extra sln Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> Co-authored-by: Pankaj Patil <pankaj.patil2099@hotmail.com> Co-authored-by: DmitryVasilevsky <60718360+DmitryVasilevsky@users.noreply.github.com> Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com> Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com> Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com> Co-authored-by: Mathias Soeken <masoeken@microsoft.com> * Apply suggestions from code review Co-authored-by: Chris Granade <chgranad@microsoft.com> * Incorporating feedback. * Build 0.17.2106.147878. Co-authored-by: Chris Granade <chgranad@microsoft.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com> Co-authored-by: Pankaj Patil <pankaj.patil2099@hotmail.com> Co-authored-by: DmitryVasilevsky <60718360+DmitryVasilevsky@users.noreply.github.com> Co-authored-by: Dmitry Vasilevsky <dmitryv@microsoft.com> Co-authored-by: Robin Kuzmin <kuzmin.robin@gmail.com> Co-authored-by: Mathias Soeken <mathias.soeken@microsoft.com> Co-authored-by: Mathias Soeken <masoeken@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated section on exceptions