This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fix QIR Simulator dll load #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottCarda-MS
approved these changes
Jun 29, 2021
Since the packaged Fullstate Simulator always uses the Windows style dll name and local development (or xplat pipelines) need to handle the platform specific library name, we will imitiate the loading patterns from .NET and try both when not on Windows.
swernli
force-pushed
the
swernli/qir-sim-dll
branch
from
a83aba5 to
f02bd35
Compare
swernli
changed the title
ScottCarda-MS
approved these changes
Jun 29, 2021
cesarzc
added a commit
that referenced
this pull request
Jul 8, 2021
* Setup controller project (#597) * Implement dependencies and tests (#626) * Refactor controller into library (#642) * Move QIR driver generator (#660) * Ignore line breaks for testing purposes. (#671) * Microsoft.Quantum.Qir.Tools package (#670) * QIR Build From Q# DLL (#658) * Add test for test.submitter.noop with Q# * Command-Line Compiler (#681) * QIR Command Line Tool - Automatically Use Required Resources (#704) * QIR Command Line Tool - Packaging Fixes (#723) * Update QIR submitter factory regex. (#728)` Co-authored-by: Bettina Heim <beheim@microsoft.com> * Fix QIR Simulator dll load (#760) * Fix QIR Simulator dll load * Fixing link (#762) * Adding entry point operation loader (#766) Co-authored-by: Zander Chocron <alchocro@microsoft.com> Co-authored-by: Sarah Marshall <sarah.marshall@microsoft.com> Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com> Co-authored-by: Scott Carda <55811729+ScottCarda-MS@users.noreply.github.com> Co-authored-by: Scott Carda <sccarda@microsoft.com> Co-authored-by: Bettina Heim <beheim@microsoft.com> Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com> Co-authored-by: Stefan J. Wernli <swernli@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the packaged Fullstate Simulator always uses the Windows style dll name and local development (or xplat pipelines) need to handle the platform specific library name, we will imitate the loading patterns from .NET and try both when not on Windows.