This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Prevent circular references when serializing Qubit values. #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@cgranade Does this need to go into main urgently? If not, could we please first pull in the simulator feature before having other merges to the runtime. |
Contributor
Author
|
Not urgent, no. Just a small bugfix I found while prototyping some Python features. |
Contributor
Author
|
Sigh, another CI failure due to the simulator crashing. |
Collaborator
|
Sigh indeed. We did have a potential fix for this, but it's tied up with #710 (see specific comment thread at #710 (comment)). Perhaps it's worth pulling that part of the change out into its own PR? |
Contributor
Author
|
@bettinaheim, @swernli: Now that |
Collaborator
|
Closing as out of date, as there is now a workaround in IQ#. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
[JsonIgnore]attribute toQubit.Valuein the C# runtime, preventing circular references when serializing values of typeQubit. This in turn allows forDisplayableUnitaryOperatorfrom Microsoft.Quantum.Standard and Microsoft.Quantum.Standard.Visualization to be sent from the IQ# kernel through to Python hosts correctly, such that Python host programs can capture operations dumped from Q# programs.