Skip to content

Improve keyboard usability #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agniuks merged 1 commit into from
Aug 31, 2022
Merged

Improve keyboard usability #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@ function RNGalleryScreenWrapper({navigation}) {
}

function RenderDrawerItem(props, i: number) {
const isDrawerOpen = getIsDrawerOpenFromState(props.navigation.getState());
return (
<DrawerItem
importantForAccessibility={isDrawerOpen ? 'auto' : 'no-hide-descendants'}
key={RNGalleryList[i].key}
label={() => {
return <Text style={styles.drawerText}>{RNGalleryList[i].key}</Text>;
Expand All @@ -141,9 +143,14 @@ function RenderDrawer(props) {

// @ts-ignore
function CustomDrawerContent(props) {
const isDrawerOpen = getIsDrawerOpenFromState(props.navigation.getState());

return (
<View style={styles.drawer}>
<TouchableHighlight
importantForAccessibility={
isDrawerOpen ? 'auto' : 'no-hide-descendants'
}
accessibilityRole="button"
accessibilityLabel="Navigation bar expanded"
{...{tooltip: 'Collapse Menu'}}
Expand All @@ -154,6 +161,9 @@ function CustomDrawerContent(props) {
<Text style={styles.icon}>&#xE700;</Text>
</TouchableHighlight>
<DrawerItem
importantForAccessibility={
isDrawerOpen ? 'auto' : 'no-hide-descendants'
}
label={() => {
return <Text style={styles.drawerText}>Home</Text>;
}}
Expand All @@ -166,6 +176,9 @@ function CustomDrawerContent(props) {
/>
<ScrollView {...props}>{RenderDrawer(props)}</ScrollView>
<DrawerItem
importantForAccessibility={
isDrawerOpen ? 'auto' : 'no-hide-descendants'
}
label={() => {
return <Text style={styles.drawerText}>Settings</Text>;
}}
Expand Down