Skip to content

[0.68-stable] Move RCTRootShadowView creation to main thread #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amgleitman merged 1 commit into from
Aug 25, 2022
Merged

[0.68-stable] Move RCTRootShadowView creation to main thread #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion React/Modules/RCTUIManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,13 @@ - (void)registerRootView:(RCTRootContentView *)rootView
_viewRegistry[reactTag] = rootView;

// Register shadow view
RCTRootShadowView *shadowView = [RCTRootShadowView new]; // TODO(macOS GH#774) - do this early to prevent RCTI18nUtil deadlock

RCTExecuteOnUIManagerQueue(^{
if (!self->_viewRegistry) {
return;
}

RCTRootShadowView *shadowView = [RCTRootShadowView new];
shadowView.availableSize = availableSize;
shadowView.reactTag = reactTag;
shadowView.viewName = NSStringFromClass([rootView class]);
Expand Down