[0.68] Handle edge case for setContentOffset with animation #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Apr 11, 2023
Collaborator
Saadnajmi
left a comment
Saadnajmi
left a comment
There was a problem hiding this comment.
Perhaps after letting it "bake" for a bit, but we probably want this change in main and 0.71-stable too?
Collaborator
|
Oh yeah... also add diff tags plz |
mischreiber
reviewed
Apr 12, 2023
mischreiber
reviewed
Apr 12, 2023
mischreiber
approved these changes
Apr 12, 2023
Author
Agreed, I think we settled on holding off on cherry picking the change until client verifies the fix.
No diff tags needed as it's already inside a macOS macro. Added a comment though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
A client downstream reported a bug in Flatlist where the clip view does not get scrolled to the offset that's being passed in when in RTL mode. Turns out this issue only repros when animation is enabled, #725 which was added a while back. Since scrollToPoint is not animatable, let's call it alongside setBoundsOrigin so that the animation is still present.
Test Plan
Verified downstream