Enclose the app path in quotes, so that the open command doesn't split it if it contains spaces
#679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This PR has already been accepted for the
masterbranch)Please select one of the following
Summary
When running
npx react-native run-macos(or locallynode node_modules/react-native-macos/local-cli/cli.js run-macos) and if the target app has spaces in the name, the current call to theopenmacOS command will split the path and only keep the last part as the name in the app, which will fail:This fix surrounds the path in quotes, which is the standard way to deal with spaces in the path. It solves the issue and introduces no other effects.
Changelog
[macOS] [Fixed] - Fixes CLI failing to launch app if the path contains spaces
Test Plan
This fix requires no further testing, as it only encloses a file path in quotes, keeping the exact same previous functionality, and preventing spaces from making
opencommand misbehave.Microsoft Reviewers: Open in CodeFlow