Skip to content

Nil check our run loop thread (#771) #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyImChris merged 1 commit into from
May 14, 2021
+8 −1
Merged

Nil check our run loop thread (#771) #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Libraries/WebSocket/RCTSRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,14 @@ - (void)_initializeStreams
- (void)_connect
{
if (!_scheduledRunloops.count) {
[self scheduleInRunLoop:[NSRunLoop RCTSR_networkRunLoop] forMode:NSDefaultRunLoopMode];
// [TODO(macOS ISS#2323203): `scheduleInRunLoop:forMode:` takes in a non-null run loop parameter so let's be safe and verify that
NSRunLoop *runLoop = [NSRunLoop RCTSR_networkRunLoop];
if (runLoop != nil) {
[self scheduleInRunLoop:runLoop forMode:NSDefaultRunLoopMode];
} else {
RCTSRLog(@"Failed connecting to RCTSR_networkRunLoop");
}
// ]TODO(macOS ISS#2323203)
}

[_outputStream open];
Expand Down