Skip to content

63 crash fix #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HeyImChris merged 16 commits into from
May 14, 2021
Merged

63 crash fix #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6f008d6
Add nullability checks (#704)
HeyImChris Feb 3, 2021
a973d02
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Feb 5, 2021
a265b19
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Feb 10, 2021
02f7a84
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Feb 18, 2021
fcc450d
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Feb 23, 2021
4f93eef
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Feb 26, 2021
6b1f7df
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Mar 3, 2021
f341932
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Mar 3, 2021
2fb8131
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Mar 8, 2021
7a9a99f
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Apr 15, 2021
2ec3692
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Apr 17, 2021
b20bc04
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Apr 20, 2021
2496154
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris Apr 26, 2021
894748c
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
HeyImChris May 13, 2021
313a8f2
Nil check our run loop thread (#771)
HeyImChris May 13, 2021
e009138
podfile lock
HeyImChris May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Libraries/WebSocket/RCTSRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,14 @@ - (void)_initializeStreams
- (void)_connect
{
if (!_scheduledRunloops.count) {
[self scheduleInRunLoop:[NSRunLoop RCTSR_networkRunLoop] forMode:NSDefaultRunLoopMode];
// [TODO(macOS ISS#2323203): `scheduleInRunLoop:forMode:` takes in a non-null run loop parameter so let's be safe and verify that
NSRunLoop *runLoop = [NSRunLoop RCTSR_networkRunLoop];
if (runLoop != nil) {
[self scheduleInRunLoop:runLoop forMode:NSDefaultRunLoopMode];
} else {
RCTSRLog(@"Failed connecting to RCTSR_networkRunLoop");
}
// ]TODO(macOS ISS#2323203)
}

[_outputStream open];
Expand Down
Loading