Xcode12.5 support in 0.62-stable#776
Merged
HeyImChris merged 1 commit intomicrosoft:0.62-stablefrom May 17, 2021
Merged
Conversation
Summary: Pull Request resolved: facebook#28362 Fixed a few compilation errors emitted by Clang 10. Changelog: [iOS] [Fixed] - Get ready for Clang 10 Differential Revision: D20549970 fbshipit-source-id: dc36a85d90d3e43a05f045feb57c6ab6ded67da7
Saadnajmi
reviewed
May 17, 2021
Saadnajmi
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Add Xcode 12.5 support for 0.62-stable. It's my understanding that this different than from what's needed for other versions and we can take those fixes in separately.
git cherry-pick 8721ee0a6b10e5bc8a5a95809aaa7b25dd5a6043Changelog
[Apple] [Bug] - Xcode 12.5 support
Test Plan
The change was already tested upstream so this is just a cherry-pick.