Skip to content

Url nil check #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HeyImChris merged 2 commits into from
Jun 1, 2021
Merged

Url nil check #788

HeyImChris merged 2 commits into from
Jun 1, 2021

Conversation

@HeyImChris
Copy link

@HeyImChris HeyImChris commented May 28, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

git cherry-pick 415abb553e33e93586e7c74a36f8eddb0266dc6d

HeyImChris and others added 2 commits May 28, 2021 13:45
@HeyImChris
Check a nil URL to fix crashes connecting to socket (microsoft#785)
aafbe25 
* Update RCTCxxBridge.mm

* Update RCTCxxBridge.mm

* nil check websocket URL

* use RCTAssertParam

Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local>
@HeyImChris
disable hermes
f279255
@HeyImChris HeyImChris self-assigned this May 28, 2021
@HeyImChris HeyImChris requested a review from tom-un as a code owner May 28, 2021 20:54
@HeyImChris HeyImChris merged commit 7d97ce2 into microsoft:0.62-stable Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@harrieshin harrieshin harrieshin approved these changes

@tom-un tom-un Awaiting requested review from tom-un tom-un is a code owner

Assignees

@HeyImChris HeyImChris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeyImChris @Saadnajmi @harrieshin