Skip to content

hackathon: react-native-viewfinder #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tido64 merged 1 commit into from
Oct 7, 2022
Merged

hackathon: react-native-viewfinder #1126

tido64 merged 1 commit into from
Oct 7, 2022

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Sep 20, 2022 •
edited
Loading

Description

This is a Fix, Hack, Learn (FHL) project.

Blocked by

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

yarn
node scripts/prepare-viewfinder.mjs
cd example

# Android
yarn build:android
yarn android

# iOS
yarn build:ios
pod install --project-directory=ios
yarn ios
Android iOS
device-2022-09-21-165034 RPReplay_Final1663675736

@tido64 tido64 requested a review from kelset September 20, 2022 12:17
@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS labels Sep 20, 2022
@tido64 tido64 removed the request for review from kelset September 20, 2022 12:31
@tido64 tido64 force-pushed the tido/experiments/viewfinder branch 8 times, most recently from a4b85b3 to cf2b3a6 Compare September 23, 2022 16:40
@tido64 tido64 force-pushed the tido/experiments/viewfinder branch from cf2b3a6 to b6a9bce Compare October 6, 2022 17:38
@github-actions github-actions bot removed platform: iOS This affects iOS platform: Android This affects Android labels Oct 6, 2022
@tido64 tido64 force-pushed the tido/experiments/viewfinder branch from b6a9bce to 1b26509 Compare October 7, 2022 10:09
@tido64 tido64 marked this pull request as ready for review October 7, 2022 10:09
@tido64 tido64 requested review from afoxman and kelset October 7, 2022 10:09
kelset
kelset approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

but could we add some documentation maybe in the readme or somewhere about this "special mode"?

@tido64
Copy link
Member Author

tido64 commented Oct 7, 2022

LGTM

but could we add some documentation maybe in the readme or somewhere about this "special mode"?

Added a wiki entry here: https://github.com/microsoft/react-native-test-app/wiki/Viewfinder

@tido64 tido64 merged commit aa26892 into trunk Oct 7, 2022
@tido64 tido64 deleted the tido/experiments/viewfinder branch October 7, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afoxman afoxman Awaiting requested review from afoxman

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tido64 @kelset