Skip to content

fix(ios): replace LaunchScreen.storyboard with UILaunchScreen#1679

Merged
tido64 merged 1 commit intotido/3.0from
tido/ios-launchscreen
Oct 30, 2023
Merged

fix(ios): replace LaunchScreen.storyboard with UILaunchScreen#1679
tido64 merged 1 commit intotido/3.0from
tido/ios-launchscreen

Conversation

@tido64
Copy link
Copy Markdown
Member

@tido64 tido64 commented Oct 30, 2023

Description

Replaces LaunchScreen.storyboard with a much simpler UILaunchScreen.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

cd example
pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

@tido64 tido64 requested review from Saadnajmi and kelset October 30, 2023 08:27
@github-actions github-actions bot added the platform: iOS This affects iOS label Oct 30, 2023
@tido64 tido64 changed the base branch from trunk to tido/3.0 October 30, 2023 08:44
tido64
tido64 commented Oct 30, 2023
View reviewed changes
ios/ReactTestApp/Info.plist
</dict>
<key>UILaunchStoryboardName</key>
<string>LaunchScreen</string>
<key>UILaunchScreen</key>
Copy link
Copy Markdown
Member Author

@tido64 tido64 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out this requires iOS 14+ so I retargeted to the 3.0 branch. I will also have to bump iOS minimum version.

kelset
kelset approved these changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - also tested with cocoapods 1.14 and all is working as expected

@tido64 tido64 merged commit 60c163f into tido/3.0 Oct 30, 2023
@tido64 tido64 deleted the tido/ios-launchscreen branch October 30, 2023 14:18
tido64 added a commit that referenced this pull request Oct 30, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
fe4ed70 
)
tido64 added a commit that referenced this pull request Nov 1, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
bb8675b 
)
tido64 added a commit that referenced this pull request Nov 30, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
c0c1bf7 
)
tido64 added a commit that referenced this pull request Dec 5, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
a93dde0 
)
tido64 added a commit that referenced this pull request Dec 6, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
61ed9b5 
)
tido64 added a commit that referenced this pull request Dec 6, 2023
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
852c383 
)
tido64 added a commit that referenced this pull request Jan 4, 2024
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
f6fb8be 
)
tido64 added a commit that referenced this pull request Jan 8, 2024
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
1a219fc 
)
tido64 added a commit that referenced this pull request Jan 10, 2024
@tido64
fix(ios): replace LaunchScreen.storyboard with UILaunchScreen (#1679
6cc02c8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: iOS This affects iOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @kelset