fix(text-matrix): tweak options for rmSync to make it more likely to succeed#1763
Merged
fix(text-matrix): tweak options for rmSync to make it more likely to succeed#1763
Conversation
tido64
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While doing my second round of testing for the 3.0 PR, I kept hitting this problem of a race condition for the rmSync method. Increasing the delay from 100 (default) to 500 made it all work smoothly.
Platforms affected
Test plan
Run
test-matrixwith any version >= 71, it works without hitting any issues.