Skip to content

Conversation

@tido64
Copy link
Member

@tido64 tido64 commented Sep 15, 2021

Description

When web debugging is enabled, nothing works due to an invariant violation:

Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'DevSettings' could not be found. Verify that a module by this name is registered in the native binary. index.bundle:24051:28
    reactConsoleErrorHandler http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:24051
    reportException http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:23996
    handleException http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:24044
    handleError http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:23869
    reportFatalError http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:1238
    guardedLoadModule http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:165
    metroRequire http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:98
    <anonymous> http://localhost:8081/index.bundle?platform=windows&dev=true&hot=false&inlineSourceMap=true:106386
    executeApplicationScript http://localhost:8081/debugger-ui/debuggerWorker.aca173c4.js:4
    onmessage http://localhost:8081/debugger-ui/debuggerWorker.aca173c4.js:4

The cause of this is the DevSettings override that we use to fetch the ReactContext instance. By implementing ReactInstanceSettings::InstanceLoaded instead, we no longer need it, but it's not available till 0.64.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

cd example
yarn
yarn install-windows-test-app --use-nuget
yarn windows
0.63 0.64
Screenshot 2021-09-15 094442 Screenshot 2021-09-15 095458

@tido64 tido64 requested a review from acoates-ms September 15, 2021 08:04
@github-actions github-actions bot added the platform: Windows This affects Windows label Sep 15, 2021
@tido64 tido64 merged commit a6eda67 into trunk Sep 15, 2021
@tido64 tido64 deleted the tido/fix-windows-debug branch September 15, 2021 18:56
@github-actions
Copy link

🎉 This PR is included in version 0.7.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tido64 tido64 added this to the 1.0 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Windows This affects Windows released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants