-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
Area: InfrastructureCode CleanupNeeds: Author FeedbackThe issue/PR needs activity from its author (label drives bot activity)The issue/PR needs activity from its author (label drives bot activity)enhancementnice-to-havep3p3no-recent-activityIssue/PR has gone stale and may be closed (label applied by bot)Issue/PR has gone stale and may be closed (label applied by bot)
Milestone
Description
This problem is raised in code review of #3729
We have nugets: boost, Hermes, J8JSI, WinUI, but we managed them in different ways.
Each time we modify a nuget version, we need make the same change across multiple projects. we need a simple way to maintain it. We may fix it by:
- package.config doesn't accept parameters like HERMES_Version. PackageReference may fix the problem
- Prefer to define the path as HERMES_Package other than package + version
<Import Project="$(HERMES_Package)\build\native\ReactNative.Hermes.Windows.targets" Condition="Exists('$(HERMES_Package)\build\native\ReactNative.Hermes.Windows.targets') AND '$(OSS_RN)' != 'true' AND '$(USE_HERMES)' == 'true'" />
<Import Project="$(V8_Package)\build\native\ReactNative.V8JSI.Windows.targets" Condition="Exists('$(V8_Package)\build\native\ReactNative.V8JSI.Windows.targets') AND '$(OSS_RN)' != 'true' AND '$(USE_V8)' == 'true'" />
is better than
<Import Project="$(SolutionDir)packages\ReactNative.Hermes.Windows.0.1.3\build\native\ReactNative.Hermes.Windows.targets" Condition="Exists('$(SolutionDir)packages\ReactNative.Hermes.Windows.0.1.3\build\native\ReactNative.Hermes.Windows.targets') AND '$(OSS_RN)' != 'true' AND '$(USE_HERMES)' == 'true'" />
<Import Project="$(SolutionDir)packages\ReactNative.V8JSI.Windows.0.1.4\build\native\ReactNative.V8JSI.Windows.targets" Condition="Exists('$(SolutionDir)packages\ReactNative.V8JSI.Windows.0.1.4\build\native\ReactNative.V8JSI.Windows.targets') AND '$(OSS_RN)' != 'true' AND '$(USE_V8)' == 'true'" />
Metadata
Metadata
Assignees
Labels
Area: InfrastructureCode CleanupNeeds: Author FeedbackThe issue/PR needs activity from its author (label drives bot activity)The issue/PR needs activity from its author (label drives bot activity)enhancementnice-to-havep3p3no-recent-activityIssue/PR has gone stale and may be closed (label applied by bot)Issue/PR has gone stale and may be closed (label applied by bot)