The release bundle builds should have --dev false flag

[namrog84]

see:

react-native-windows/packages/microsoft-reactnative-sampleapps/windows/SampleAppCPP/SampleAppCpp.vcxproj

Line 179 in 4a1c8bb

npx --no-install react-native bundle --platform windows --entry-file index.windows.js --bundle-output windows/SampleAppCpp/Bundle/index.windows.bundle --assets-dest windows/SampleAppCpp/Bundle

react-native-windows/vnext/local-cli/generator-windows/templates/cpp/proj/MyApp.vcxproj

Line 163 in 744a02c

npx --no-install react-native bundle --platform windows --entry-file index.js --bundle-output windows/$(SolutionName)/Bundle/index.windows.bundle --assets-dest windows/$(SolutionName)/Bundle

If running this command:
npx react-native bundle --help

you can see its defaulting to true
...
--dev [boolean] If false, warnings are disabled and the bundle is minified (default: true)
...

This is what can help lead to some 'yellow box' warnings appearing in release builds.

[namrog84]

RN set's it using a flag for for android. Thus RNW should align with RN.
https://github.com/facebook/react-native/blob/1fb815ed4314c1396999e64354ca0b5d4ed83663/react.gradle#L156

[chrisglein]

@namrog84 is this fixed with your PR?
(FYI you can use "Fixes #asdf" and github will automatically create a link and resolve)

[namrog84]

I abandoned my PR and my work trying to address this because things moved into an area I am not as familiar with, as I was getting the impression I was stepping on toes on other people works/plans recently for redesign of packaging/bundling/etc... and other priorities have come up, so I am taking a step back from trying to address this at the moment.

When I get some extra time again, I'll be glad to take another crack at it, but it probably wont happen for a little bit now.