-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Labels
API: CompletionArea: ThemingDeforkingDeliverableMajor item tracked for top-level planning in ADOMajor item tracked for top-level planning in ADONeeds: PM DesignNew feature or requestNew feature or requestResolution: DuplicateWill flag the issue to be closed by a bot after a 1 day grace period (label used by bot)Will flag the issue to be closed by a bot after a 1 day grace period (label used by bot)
Milestone
Description
React Native 0.62 adds a new Appearance Module, which allows apps to query light mode vs dark mode. See https://medium.com/@rossbulat/theming-in-react-native-explained-ac40d0d2e15c
This conflicts with out existing custom AppTheme module, which provides the same functionality, but adds information about high contrast, and the high contrast palette.
We should figure out our story here. A few options immediately come to mind:
- Keep both around: This seems confusing to users, but there is some Windows specific theming information we might want to expose in the future, like "personalization color" (highlight color).
- Add APIs to Appearance: We should not do this. It will just add debt.
- Add
AppearanceWindowswith a superset of functionality: This seems cleanish if we can't logically split other things off. - Split some functionality into
AccessibilityInfoandPlatformColor: We already have Windows specific accessibility needs, and these APIs already differ by platform. For things like whether high contrast is enabled, that seems like a potentially better home. High contrast palette, or personalization color could work with PlatformColor, which we should have soon.
FYI @marlenecota
Metadata
Metadata
Assignees
Labels
API: CompletionArea: ThemingDeforkingDeliverableMajor item tracked for top-level planning in ADOMajor item tracked for top-level planning in ADONeeds: PM DesignNew feature or requestNew feature or requestResolution: DuplicateWill flag the issue to be closed by a bot after a 1 day grace period (label used by bot)Will flag the issue to be closed by a bot after a 1 day grace period (label used by bot)