-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed as not planned
Labels
Area: Debug InfrastructureArea: Test InfrastructureRecommend: Not PlannedRecommend that issue should be given Not Planned milestone.Recommend that issue should be given Not Planned milestone.enhancement
Milestone
Description
In #4575 I refactored our ViewManagers to report when a property wasn't handled by them.
Some properties can be handled by ShadowNodes, either exclusively or in addition to ViewManagers. For example, the height property has special treatment in the Icon shadow node, but then it also needs to be handled by the FrameworkElement ViewManager.
All this means that we also need to keep track of whether a shadow node has looked at a property before it passed it onto the view manager.
- Move updateProperties up to the base class only
- Change subclasses' implementations of updateProperties to do updateProperty (and return bool, and have each class delegate to Super::updateProperty).
- When ShadowNode base finishes asking updateProperty, and it goes to ask the viewmanager, it has to pass whether updateProperty was handled or not (as a new parameter to ViewManagerBase::UpdateProperties).
In reality there probably may not be a reason for ViewManagerBase::UpdateProperties to do anything anymore and we may be able to live with only VMB::UpdateProperty (and do the multi-item part in ShadowNodeBase).
Metadata
Metadata
Assignees
Labels
Area: Debug InfrastructureArea: Test InfrastructureRecommend: Not PlannedRecommend that issue should be given Not Planned milestone.Recommend that issue should be given Not Planned milestone.enhancement