Crash When Trying to Load Certain Images on Pre-1903

[NickGerleman]

Hitting this deterministically running integration tests in CI, which run on an older version of Windows Server 2019. In ReactImage.cpp we have the following code:

            if (args.Status() == winrt::LoadedImageSourceLoadStatus::Success) {
              ...

                // If we are dynamically switching the resizeMode to 'repeat', then
                // the SizeChanged event has already fired and the ReactImageBrush's
                // size has not been set. Use ActualSize in that case.
                if (compositionBrush->AvailableSize() == winrt::Size{0, 0}) {
                  compositionBrush->AvailableSize(strong_this->ActualSize());
                }

                ...
            }

ActualSize() is only available in IUIElement10 introduced in 1903, which we fail to QI to and crash.

This specific code was added in #3712 which made it into later builds of 0.60. It's possible the path is newly hit though. Not sure why E2ETest isn't hitting this.

I think this is happening when we try to load the "x" close button image for LogBox. It's possible it has some effect we're not guarding on.

[NickGerleman]

Can be reproduced enabling Slider in the MountComponentTests integration test

[NickGerleman]

This seems to happen any time we redbox/yellowbox which is nasty for integration tests since we crash instead of reporting back the exception.

[NickGerleman]

Confirmed this happens when showing the mini logbox. I.e. this

This doesn't effect E2ETest since is runs the release build which doesn't show LogBox.

[chrisglein]

Comment from Andrew is that maybe this can just use ActualWidth and ActualHeight separately if those exist.

[NickGerleman]

@marlenecota have any ideas on when you'll be able to address this one? It currently creates a pretty bad experience for integration test failures.