Fix compiler issue for older versions of C++/WinRT #10278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In older versions of cppwinrt, the header generated for Windows.Foundation.Collections.h do not include the begin and end methods for `IIterable`. This just switches the logic for compatibility with older versions of cppwinrt. Note, it may also include a bug fix where a comma separator is not emitted between headers from the request header collection and headers from the content header collection.
asklar
approved these changes
Jul 19, 2022
Contributor
Author
|
@asklar - looks like there are some flaky tests. Mind bumping AZP to re-run? |
rozele
added a commit
to rozele/react-native-windows
that referenced
this pull request
Oct 23, 2022
…10278) In older versions of cppwinrt, the header generated for Windows.Foundation.Collections.h do not include the begin and end methods for `IIterable`. This just switches the logic for compatibility with older versions of cppwinrt. Note, it may also include a bug fix where a comma separator is not emitted between headers from the request header collection and headers from the content header collection.
JunielKatarn
pushed a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Dec 21, 2022
* Fix compiler issue for older versions of C++/WinRT In older versions of cppwinrt, the header generated for Windows.Foundation.Collections.h do not include the begin and end methods for `IIterable`. This just switches the logic for compatibility with older versions of cppwinrt. Note, it may also include a bug fix where a comma separator is not emitted between headers from the request header collection and headers from the content header collection. * Change files
This was referenced Dec 21, 2022
JunielKatarn
added a commit
that referenced
this pull request
Dec 22, 2022
* Fix compiler issue for older versions of C++/WinRT (#10278) * Fix compiler issue for older versions of C++/WinRT In older versions of cppwinrt, the header generated for Windows.Foundation.Collections.h do not include the begin and end methods for `IIterable`. This just switches the logic for compatibility with older versions of cppwinrt. Note, it may also include a bug fix where a comma separator is not emitted between headers from the request header collection and headers from the content header collection. * Change files * Remove change file * Change files * Test Access-Control-Request-Headers (#11031) * Add test ValidatePreflightResponseMainAndContentHeadersSucceeds * Allow resetting static origin * Remove change file Co-authored-by: Eric Rozell <erozell@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
In older versions of cppwinrt, the header generated for Windows.Foundation.Collections.h do not include the begin and end methods for
IIterable.What
This just switches the logic for compatibility with older versions of cppwinrt. Note, it may also include a bug fix where a comma separator is not emitted between headers from the request header collection and headers from the content header collection.
Microsoft Reviewers: Open in CodeFlow